Removes redundant listeners between a Fragment and an Activity#520
Open
igorgur wants to merge 1 commit intoandroid:dev-todo-mvvm-livefrom
Open
Removes redundant listeners between a Fragment and an Activity#520igorgur wants to merge 1 commit intoandroid:dev-todo-mvvm-livefrom
igorgur wants to merge 1 commit intoandroid:dev-todo-mvvm-livefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like the code includes callbacks (
*Navigator.java) which act as a middle man between the Fragments and Activities. That approach should be fine for other architectures and for the 'old' way that has been used. ViewModel should dispatch events to observers and that exactly implemented in the sample code, but the unused interfaces cause a confusion in readability.