Skip to content

#507 Todo mvp rxjava empty task fix #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lebedevsd wants to merge 2 commits into
base: todo-mvp-rxjava
Choose a base branch
from
Open

#507 Todo mvp rxjava empty task fix #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7382c96
Update AddEditTaskPresenter.java
Lebedevsd Feb 13, 2018
d5cc076
added test to cover empty edit scenario
Lebedevsd Feb 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...com/example/android/architecture/blueprints/todoapp/addedittask/AddEditTaskPresenter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,13 @@ private void updateTask(String title, String description) {
if (isNewTask()) {
throw new RuntimeException("updateTask() was called but task is new.");
}
mTasksRepository.saveTask(new Task(title, description, mTaskId));
mAddTaskView.showTasksList(); // After an edit, go back to the list.

Task newTask = new Task(title, description, mTaskId);
if (newTask.isEmpty()) {
mAddTaskView.showEmptyTaskError();
} else {
mTasksRepository.saveTask(newTask);
mAddTaskView.showTasksList(); // After an edit, go back to the list.
}
}
}
13 changes: 13 additions & 0 deletions ...example/android/architecture/blueprints/todoapp/addedittask/AddEditTaskPresenterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,19 @@ public void saveTask_emptyTaskShowsErrorUi() {
verify(mAddEditTaskView).showEmptyTaskError();
}

@Test
public void saveExistingTaskWithEmptyNameToRepository_emptyTaskShowsErrorUi() {
// Get a reference to the class under test
mAddEditTaskPresenter = new AddEditTaskPresenter(
"1", mTasksRepository, mAddEditTaskView, true, mSchedulerProvider);

// When the presenter is asked to save an empty task
mAddEditTaskPresenter.saveTask("", "");

// Then an empty not error is shown in the UI
verify(mAddEditTaskView).showEmptyTaskError();
}

@Test
public void saveExistingTaskToRepository_showsSuccessMessageUi() {
// Get a reference to the class under test
Expand Down