Mobile presentation refactoring in preparation for other form factors - #48
Open
pflammertsma wants to merge 3 commits into
Open
Mobile presentation refactoring in preparation for other form factors#48pflammertsma wants to merge 3 commits into
pflammertsma wants to merge 3 commits into
Conversation
added 2 commits
July 31, 2026 14:42
…faces - Add FormFactorUtils to detect TV, Mobile, Wear, Auto, and XR devices. - Define compile-time layout contract interfaces (AgentDemoScreenLayout, DebuggingScreenLayout, SettingsScreenLayout, ConnectedAppsScreenLayout) to decouple screen routers from form-factor presentation. TAG=agy CONV=93e51fa6-7028-4707-8a32-f7af65eb2041
- Extract mobile screen composables into ui/mobile/ (MobileAgentDemoContent, MobileDebuggingContent, MobileSettingsContent, MobileConnectedAppsContent). - Update top-level screen files (AgentDemoScreen, DebuggingScreen, SettingsScreen, ConnectedAppsScreen) to delegate UI rendering to ScreenLayoutFactory. - Zero visual changes (100% parity with existing mobile UX). TAG=agy CONV=93e51fa6-7028-4707-8a32-f7af65eb2041
Member
Author
|
Please review #47 first as this PR includes the same commits. |
pflammertsma
force-pushed
the
pr/mobile-presentation-refactor
branch
3 times, most recently
from
July 31, 2026 21:04
aa10e4d to
ec13895
Compare
- Extract mobile screen composables into ui/mobile/ (MobileAgentDemoContent, MobileDebuggingContent, MobileSettingsContent, MobileConnectedAppsContent). - Update top-level screen files (AgentDemoScreen, DebuggingScreen, SettingsScreen, ConnectedAppsScreen) to delegate UI rendering to ScreenLayoutFactory. - Zero visual changes (100% parity with existing mobile UX). TAG=agy CONV=93e51fa6-7028-4707-8a32-f7af65eb2041
pflammertsma
force-pushed
the
pr/mobile-presentation-refactor
branch
from
July 31, 2026 21:10
ec13895 to
bbc99b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modularizes the existing mobile screen implementations into dedicated layout composables (
ui/mobile/) and introduces compile-time layout contracts for top-level screens. This establishes the architectural foundation required to support additional device form factors (such as Android TV) without bloating top-level screen routers.Key Changes
MobileAgentDemoContent,MobileDebuggingContent,MobileSettingsContent,MobileConnectedAppsContent), using layout contracts for specific screens.