Implement multi-form-factor presentation separation & compile-time layout contracts - #32
Implement multi-form-factor presentation separation & compile-time layout contracts#32pflammertsma wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces adaptive layout support for Android TV across the App Functions Agent application. It refactors key screens (Agent Demo, Connected Apps, Debugging, and Settings) into interface contracts with separate Mobile and TV implementations, adds TV-specific components like TvSurfaceTextField, and updates the main navigation to adapt to the TV form factor. The review feedback focuses on improving the Android TV D-pad navigation experience, specifically addressing focus loss when exiting editing mode or closing dropdowns, resolving nested focus issues with switches, and ensuring card highlights persist when child inputs are focused.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
pflammertsma
changed the title
eebb288 to
d0bc8df
Compare
|
We just enabled GitHub Actions on this project. Please re-base onto current main before we start reviewing this pull request. |
2e18f8c to
b255892
Compare
|
Rebased onto |
…ime layout contracts - Add FormFactor enum capability resolver supporting TV, Mobile, Wear, Auto, and XR. - Modularize screen presentation into isolated mobile/ and tv/ packages. - Implement compile-time layout contracts (DebuggingScreenLayout, AgentDemoScreenLayout, SettingsScreenLayout, ConnectedAppsScreenLayout). - Add D-Pad focus handling, stationary dialog container, and widescreen side-by-side layout for TV. - Update vector assets and Leanback banner launcher metadata. TAG=agy CONV=2bd6b504-08a0-463f-9439-1c30216f4e02
b255892 to
8a9aa8a
Compare
|
@pflammertsma could you please split this pr into smaller atomic PRs so it's easier to review? And could you please add before/after screenshots for visual changes? |
3 participants
What I have done and why