Skip to content

Recognize Snowflake CLONE as a keyword #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Victor-Su-Ortiz wants to merge 1 commit into
base: master
Choose a base branch
from
+45 −0
Draft

Recognize Snowflake CLONE as a keyword #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sqlparse/keywords.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,6 +1081,7 @@ def find_delimited_spans(text):

KEYWORDS_SNOWFLAKE = {
'ACCOUNT': tokens.Keyword,
'CLONE': tokens.Keyword,
'GSCLUSTER': tokens.Keyword,
'ISSUE': tokens.Keyword,
'ORGANIZATION': tokens.Keyword,
Expand Down
44 changes: 44 additions & 0 deletions tests/test_regressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,50 @@ def test_keyword_before_qualified_name_still_grouped():
assert ident is not None


@pytest.mark.parametrize(('stmt', 'source', 'destination', 'formatted'), [
('CREATE DATABASE DATABASE_NAME CLONE MASTER_DATABASE;',
'DATABASE_NAME', 'MASTER_DATABASE',
'CREATE DATABASE DATABASE_NAME CLONE MASTER_DATABASE;'),
('create schema source_schema clone target_schema;',
'source_schema', 'target_schema',
'CREATE SCHEMA source_schema CLONE target_schema;'),
('CrEaTe TaBlE source_table ClOnE target_table;',
'source_table', 'target_table',
'CREATE TABLE source_table CLONE target_table;'),
('CREATE DATABASE "DATABASE NAME" CLONE "MASTER DATABASE";',
'"DATABASE NAME"', '"MASTER DATABASE"',
'CREATE DATABASE "DATABASE NAME" CLONE "MASTER DATABASE";'),
('CREATE SCHEMA "SCHEMA NAME" CLONE "MASTER SCHEMA";',
'"SCHEMA NAME"', '"MASTER SCHEMA"',
'CREATE SCHEMA "SCHEMA NAME" CLONE "MASTER SCHEMA";'),
('CREATE TABLE "TABLE NAME" CLONE "MASTER TABLE";',
'"TABLE NAME"', '"MASTER TABLE"',
'CREATE TABLE "TABLE NAME" CLONE "MASTER TABLE";'),
])
def test_snowflake_clone_is_a_separate_keyword(stmt, source, destination,
formatted):
parsed = sqlparse.parse(stmt)[0]
assert str(parsed) == stmt
assert parsed.get_type() == 'CREATE'

clone = [token for token in parsed.tokens
if token.ttype is T.Keyword and token.normalized == 'CLONE']
assert len(clone) == 1
identifiers = [token for token in parsed.tokens
if isinstance(token, sql.Identifier)]
assert [str(token) for token in identifiers] == [source, destination]
assert sqlparse.format(stmt, keyword_case='upper') == formatted


def test_snowflake_create_without_clone_preserves_identifier():
stmt = 'CREATE DATABASE DATABASE_NAME;'
parsed = sqlparse.parse(stmt)[0]
assert str(parsed) == stmt
assert parsed.get_type() == 'CREATE'
assert [str(token) for token in parsed.tokens
if isinstance(token, sql.Identifier)] == ['DATABASE_NAME']


@pytest.fixture
def limit_recursion():
curr_limit = sys.getrecursionlimit()
Expand Down