fix: correct phone masks for Israel, UAE, and Germany#16
Open
itaisatati wants to merge 3 commits intoanday013:mainfrom
Open
fix: correct phone masks for Israel, UAE, and Germany#16itaisatati wants to merge 3 commits intoanday013:mainfrom
itaisatati wants to merge 3 commits intoanday013:mainfrom
Conversation
The IL mask (X-XXX-XXXX) only covered 8-digit fixed-line numbers. Mobile numbers (prefixes 50-59) require 9 digits (XX-XXX-XXXX), making it impossible to enter a valid Israeli mobile number.
The AE mask (X-XXX-XXXX) only covered 8-digit landline numbers. Mobile numbers (prefixes 50-58) require 9 digits (XX-XXX-XXXX), making it impossible to enter a valid UAE mobile number.
The DE mask (XXX-XXX) was only 6 digits, making it impossible to enter any valid German number. German numbers after +49 are 10 digits: 3-digit area/mobile code + 7-digit subscriber number (e.g. 151-XXXXXXX for mobile, 30-XXXXXXXX for Berlin). Updated to (XXX) XXX-XXXX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed 3 entries in
MASK_PER_COUNTRY:X-XXX-XXXXtoXX-XXX-XXXX.X-XXX-XXXXtoXX-XXX-XXXX.XXX-XXXto(XXX) XXX-XXXX.