fix: support RN 0.85 hidden input absolute fill behavior#117
Open
fix: support RN 0.85 hidden input absolute fill behavior#117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
StyleSheet.absoluteFillObjectwhich caused the OTP hiddenTextInputto affect layout and make OTP cells move when filled.dist) so all consumers get the RN 0.85-compatible behavior.Description
...StyleSheet.absoluteFillObjectfromhiddenInputinsrc/OtpInput/OtpInput.styles.tsand keep only the platform-visibility rules (opacity/color).StyleSheet.absoluteFilldirectly in the renderedTextInputstyle array insrc/OtpInput/OtpInput.tsxviastyle={[StyleSheet.absoluteFill, styles.hiddenInput, textInputProps?.style]}to ensure absolute overlay behavior on RN 0.85.src/OtpInput/__tests__/OtpInput.test.tsxthat asserts the hidden input has absolute positioning and thus cannot affect OTP cell spacing, and update the snapshot accordingly.tscbuild so the produceddistoutput matches the source change.Testing
npm test -- --runInBand -uand all tests passed with the snapshot updated successfully.npm run ts:check(tsc --noEmit) and it completed without errors.npm run build:prod(tsc -p tsconfig.prod.json) and the production build completed successfully.absoluteFillObjectoccurrences insrcordistafter the change.Codex Task