Repository navigation
fix(decompose): read task rows and noted full covers as people write them - #56
Open
ancelin-code wants to merge 1 commit into
Open
ancelin-code wants to merge 1 commit into
ancelin-code wants to merge 1 commit into
Conversation
…them Under Epics, any bullet starting with a backtick was read as a task id, so a note such as "`search-001`'s open questions" failed as an unknown task. A task row is now the backticked id alone or followed by a space or a colon. A full cover with a note, "- R7: vectors rebuilt", failed validation as unreadable, and coverage.sh read its id as "R7:", so the requirement never counted as covered. Both now accept the note and ignore it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Two parsing quirks met while decomposing the tiroir
retrievalcut (feedback item 5):## Epics, any bullet starting with a backtick counted as a task row, so the note- `search-001`'s open questions …failed as an unknown task. Notes had to move to another section. A task row is now- `<id>`alone or followed by a space or a colon, which covers the template's- `<id>` - <title>, and the note no longer matches.- R7: vectors rebuiltunder## Coversfailed as "unreadable Covers line". I went further than a better message: a note on a full cover is now allowed. Fixing it turned up a second bug the feedback did not mention:coverage.shread that line's id asR7:, so the requirement never counted as covered. Both scripts now strip the colon.How to review
etabli-decompose/scripts/validate-tasks.sh: the row pattern insummary_rows, and one more branch incovers_of. A noted full cover still has its id checked against the requirements; a test covers it.etabli-status/scripts/coverage.sh: onesub(/:$/, "", req).conventions.md: the Covers example gains a noted full cover.How to try it
The new tests fail on
developand pass here: three of them, for the epic note, the noted full cover in the validator, and the same line incoverage.sh.Does it earn its place?
This loosens rules rather than adding one. The rule that a partial cover must say what it does is kept, since without it nobody can tell what is left of the requirement. The rule that a full cover must carry nothing protected no one. Recorded in
CHANGELOG.md.🤖 Generated with Claude Code