Repository navigation
fix(status): count an open draft pull request as in review - #55
Open
ancelin-code wants to merge 1 commit into
Open
ancelin-code wants to merge 1 commit into
ancelin-code wants to merge 1 commit into
Conversation
A bench opens its draft only after its sessions end, so a draft already waits on a person; reading it as in-progress made a finished bench look like a running one, and where.sh printed no REVIEW rows for it. Any open pull request is now in-review. follow.sh announces IN-REVIEW only for benches it has no log for, since PUBLISHED announces its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
After
PUBLISHED, a task stayedin-progressuntil its pull request left draft, so "a bench is running" and "a draft waits on a person" looked the same, andwhere.shprinted noREVIEWrows for the draft (feedback item 4).The rule behind it rested on an outdated assumption, that a bench opens its draft early and works in it. In fact
publish-bench.shopens the draft only after both sessions have ended. So the rule is deleted: any open pull request, draft or not, isin-review.How to review
etabli-status/scripts/status.sh: the open query loses itsisDraftfilter. The rest of the diff is the state's description, in the script, the status skill and the shared conventions.etabli-orchestrator/scripts/follow.sh: without a fix, a bench run here would printPUBLISHED, thenIN-REVIEWonce its draft appeared.IN-REVIEWis now printed only when this machine has no log for the task, so it still announces pull requests from benches run elsewhere.where.shneeds no change: drafts now reach itsREVIEWrows throughin-review.I chose this over a new
publishedstate. A new state would need teaching towhere.sh,follow.sh,standup.sh, the tests and the docs, for a difference GitHub already shows.How to try it
With a bench's draft pull request open,
sh .agents/skills/etabli-orchestrator/scripts/where.shlists it underREVIEWwith its lenses, andstatus.sh --in-reviewincludes it.Does it earn its place?
This removes a rule rather than adding one. It changes a state people read: a draft that showed
in-progressnow showsin-review, andIN-REVIEWno longer means "left draft". Recorded under Changed inCHANGELOG.md.🤖 Generated with Claude Code