Repository navigation
fix(follow): say why task state could not be read - #54
Open
ancelin-code wants to merge 1 commit into
Open
ancelin-code wants to merge 1 commit into
ancelin-code wants to merge 1 commit into
Conversation
follow.sh discarded status.sh's stderr, and status.sh discarded gh's, so a proxy timeout surfaced only as "task state could not be read". The ERROR event now carries status.sh's first line, which carries gh's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
follow.shprintedERROR task state could not be read (attempt N)a few times an hour in the tiroirretrievalcut, with no cause (feedback item 3). Finding it meant wrappingstatus.shwith--status-script. The cause was hidden twice:follow.shranstatus.sh 2>/dev/null, andstatus.shrangh pr list … 2>/dev/null.Now
status.shaddsgh's first stderr line to its "gh could not list pull requests" message, andfollow.shaddsstatus.sh's first stderr line, minus itsERRORprefix, to the event:How to review
Two small hunks:
pr_headsinetabli-status/scripts/status.sh, and the top of the poll loop inetabli-orchestrator/scripts/follow.sh. Only the first line is kept, so a stack of output cannot flood the event stream.How to try it
Point
follow.sh --status-scriptat a script that writes a line to stderr and exits 1: the event ends with that line. The tests do exactly that, and a fakeghthat fails with a reason shows it instatus.sh's error.Does it earn its place?
A proxy timeout and an expired
ghlogin need different fixes, and an agent watching the loop cannot tell them apart without the cause. The event keeps its name and first field, so a watcher matchingERRORis unaffected.🤖 Generated with Claude Code