-
Notifications
You must be signed in to change notification settings - Fork 915
Add Support for LTC3208 #3022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Support for LTC3208 #3022
Conversation
47e5181 to
d2fada2
Compare
edelweiseescala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, just sharing what I've learned so far
d2fada2 to
57ca070
Compare
|
Changelog V2:
|
57ca070 to
999b8f4
Compare
999b8f4 to
20cc126
Compare
|
Changelog V3:
|
| if (ret) { | ||
| dev_err(&client->dev, "Error Writing brightness to register %u\n", reg); | ||
| return ret; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I would just return regmap()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exposed to user space by brightness set and is not used in the probe function, if so should I still remove this dev_err?
Add Documentation for LTC3208 Multidisplay LED Driver. Signed-off-by: Jan Carlo Roleda <jancarlo.roleda@analog.com>
20cc126 to
e3af1f6
Compare
|
Changelog V4:
leds-ltc3208.c
|
e3af1f6 to
5d8624c
Compare
Kernel driver implementation for LTC3208 Multidisplay LED Driver Signed-off-by: Jan Carlo Roleda <jancarlo.roleda@analog.com>
Add entry to Kconfig for LTC3208 driver Signed-off-by: Jan Carlo Roleda <jancarlo.roleda@analog.com>
5d8624c to
6e8165c
Compare
|
Changelog V4.1:
|
PR Description
PR Type
PR Checklist