-
Notifications
You must be signed in to change notification settings - Fork 915
iio: dac: Add AD5413 support #2786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) | ||
| %YAML 1.2 | ||
| --- | ||
| $id: http://devicetree.org/schemas/iio/dac/adi,ad5413.yaml# | ||
| $schema: http://devicetree.org/meta-schemas/core.yaml# | ||
|
|
||
| title: Analog Devices AD5413 DAC | ||
|
|
||
| maintainers: | ||
| - Bruce Tsao <bruce.tsao@analog.com> | ||
|
|
||
| properties: | ||
| compatible: | ||
| const: adi,ad5413 | ||
|
|
||
| reg: | ||
| maxItems: 1 | ||
|
|
||
| spi-max-frequency: | ||
| maximum: 50000000 | ||
|
|
||
| reset-gpios: true | ||
|
|
||
| avdd-supply: | ||
| description: Analog positive supply (AVDD) | ||
|
|
||
| dvdd-supply: | ||
| description: Digital positive supply (DVDD) | ||
|
|
||
| avss-supply: | ||
| description: Analog negative supply (AVSS) | ||
|
|
||
| adi,range-microvolt: | ||
| description: Voltage output range <min, max> in microvolts | ||
| oneOf: | ||
| - items: | ||
| - const: -10500000 | ||
| - const: 10500000 | ||
| - items: | ||
| - const: -12600000 | ||
| - const: 12600000 | ||
|
|
||
| adi,range-microamp: | ||
| description: Current output range <min, max> in microamps | ||
| items: | ||
| - const: 0 | ||
| - const: 24000 | ||
|
|
||
| adi,slew-time-us: | ||
dlech marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| description: Output digital slew control time in microseconds | ||
| minimum: 0 | ||
| maximum: 1000000 | ||
| default: 0 | ||
|
|
||
| required: | ||
dlech marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - compatible | ||
| - reg | ||
| - avdd-supply | ||
| - dvdd-supply | ||
| - avss-supply | ||
|
|
||
| allOf: | ||
| - $ref: /schemas/spi/spi-peripheral-props.yaml# | ||
| - oneOf: | ||
| - required: ['adi,range-microamp'] | ||
| - required: ['adi,range-microvolt'] | ||
BruceTsaoADI marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| unevaluatedProperties: false | ||
|
|
||
| examples: | ||
| - | | ||
| spi { | ||
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
||
| dac@0 { | ||
| compatible = "adi,ad5413"; | ||
| reg = <0>; | ||
| spi-max-frequency = <1000000>; | ||
| reset-gpios = <&gpio 0 1>; /* 1 = active low */ | ||
| avdd-supply = <&avdd>; | ||
| dvdd-supply = <&dvdd>; | ||
| avss-supply = <&avss>; | ||
| adi,range-microamp = <0 24000>; | ||
| adi,slew-time-us = <125>; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The bindings patch should be one separate commit.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed. The DT bindings are now in a separate commit: |
||
| }; | ||
| }; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just about the commit message. Do not mention "bindings" in the git subject, that's implied :). Instead, something like
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated the commit subject as suggested. It now uses: |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -96,6 +96,7 @@ config IIO_ALL_ADI_DRIVERS | |
| imply AD5360 | ||
| imply AD5380 | ||
| imply AD5421 | ||
| imply AD5413 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also a separate commit. The last one typically...
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed. The Kconfig.adi change is now placed in its own commit ("iio: Kconfig.adi: Add AD5413 to IIO_ALL_ADI_DRIVERS"). |
||
| imply AD5624R_SPI if SPI | ||
| imply AD3552R | ||
| imply AD3552R_HS | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.