Portable versions of NativeMessageHandler and NativeCookieHandler#189
Open
ncruces wants to merge 2 commits intoanaisbetts:masterfrom
ncruces:windows
Open
Portable versions of NativeMessageHandler and NativeCookieHandler#189ncruces wants to merge 2 commits intoanaisbetts:masterfrom ncruces:windows
ncruces wants to merge 2 commits intoanaisbetts:masterfrom
ncruces:windows
Conversation
Author
|
Any interest in me further pursuing this?
|
|
I'd like to see this officially supported. Right now I can't just drop in NativeMessageHandler instead of HttpClientHandler because the CookieContainer contents are ignored by NativeMessageHandler and I need to send cookies with my request. (Using with Xamarin iOS/Android) |
|
+1, I think this is a great idea as well. This would allow the handlers to be used reliably in PCLs without any fear of breaking for Windows clients, while providing the speed benefits when possible on iOS/Android. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first try at fixing #188. Adapted from #175.
NativeCookieHandlermostly works, though API mismatches forces us to jump through some hoops.I based this off #187, which I think is a good idea?
NativeMessageHandlerstill has some gaps:throwOnCaptiveNetworkworks;customSSLVerificationdoesn't seem to require anything special;DisableCachingwould require inheriting fromWebRequestHandlerwhich isn't portable (full .NET only);RegisterForProgressis yet to be done.Any feedback would be greatly appreciated.