Repository navigation
cpio: Reject malformed header fields - #395
Merged
Merged
Conversation
read() parses the hex fields of a newc header with int(), which also accepts a sign, blanks and underscores. For an entry named demo, a filesize of -0000074 points the next header back at the same one, and read() then yields that entry forever. An archive from outside the project, such as the payload of a source rpm, can contain such a field. Let's refuse a header that contains anything but hex digits. Signed-off-by: Daan De Meyer <daan@amutable.com>
martinpitt
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read() parses the hex fields of a newc header with int(), which also accepts a sign, blanks and
underscores. A negative filesize can point the next header back at the same one, and read() then yields
that entry forever. Let's refuse a header that contains anything but hex digits, since archives from
outside the project, such as the payload of a source rpm, can contain such a field.