Repository navigation
snapshotter: Retry short downloads and time out reads - #394
Merged
Merged
Conversation
download() opens a URL without a timeout, so a server that stops sending blocks a refresh forever. A server that closes the connection early also goes unnoticed when no size was stated: http.client returns the short body without an error, and a chunked transfer that ends early raises IncompleteRead, which with_retries() doesn't retry. Let's time out each read after a minute and turn both kinds of early end into a ConnectionError, which with_retries() retries. Signed-off-by: Daan De Meyer <daan@amutable.com>
Member
|
this flake repeats, but it's obviously unrelated to this PR. I'll have a look at it separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
download() opens a URL without a timeout, so a server that stops sending blocks a refresh forever. A
server that closes the connection early also goes unnoticed when no size was stated, and a chunked
transfer that ends early raises IncompleteRead, which with_retries() doesn't retry. Let's time out each
read after a minute and turn both kinds of early end into a ConnectionError, which with_retries() retries.