Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions templates/agent/handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ def get_item(item_id: str) -> dict:
try:
item = repository.get_item(item_id)
if not item:
return {"error": f"Item {item_id} not found"}
return {"error": "Item not found"}
return Item.model_validate(item).dump()
except Exception as error:
logger.error("Failed to get item", extra={"itemId": item_id}, exc_info=error)
return {"error": f"Failed to get item with ID '{item_id}'"}
return {"error": "Failed to get item"}


@tracer.capture_method
Expand All @@ -59,7 +59,7 @@ def create_item(item_id: str, name: str, description: str | None = None) -> dict
return item
except Exception as error:
logger.error("Failed to create item", extra={"itemId": item_id}, exc_info=error)
return {"error": f"Failed to create item with ID '{item_id}'"}
return {"error": "Failed to create item"}


@logger.inject_lambda_context
Expand Down
4 changes: 2 additions & 2 deletions templates/graphql/handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def get_item(id: str) -> dict | None:
return Item.model_validate(item).dump()
except Exception as error:
logger.error("Failed to get item", extra={"itemId": id}, exc_info=error)
raise RuntimeError(f"Failed to get item with ID '{id}'") from None
raise RuntimeError("Failed to get item") from None


@app.resolver(type_name="Query", field_name="listItems")
Expand Down Expand Up @@ -70,7 +70,7 @@ def create_item(name: str) -> dict:
return item
except (ValidationError, Exception) as error:
logger.error("Failed to create item", extra={"itemName": name}, exc_info=error)
raise RuntimeError(f"Failed to create item with name '{name}'") from None
raise RuntimeError("Failed to create item") from None


@logger.inject_lambda_context(correlation_id_path=correlation_paths.APPSYNC_RESOLVER)
Expand Down
4 changes: 2 additions & 2 deletions tests/agent/test_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def test_handler_get_item_not_found():
result = get_item("2")

assert "error" in result
assert "not found" in result["error"]
assert result["error"] == "Item not found"


def test_handler_create_item(repository):
Expand Down Expand Up @@ -117,7 +117,7 @@ def test_error_handling_sanitization(mocker):

assert "error" in result
assert "Database connection failed" not in result["error"]
assert "Failed to get item with ID '123'" in result["error"]
assert result["error"] == "Failed to get item"


if __name__ == "__main__":
Expand Down