馃悰 match textarea pattern polyfill against the whole value - #40542
Open
madib06ops wants to merge 1 commit into
Open
馃悰 match textarea pattern polyfill against the whole value#40542madib06ops wants to merge 1 commit into
madib06ops wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The textarea
patternpolyfill incheckInputValiditycompiles the author pattern asnew RegExp('^' + pattern + '$', 'm'), which does not match native<input pattern>semantics. Themflag lets^and$match at internal line breaks, and without a non-capturing group a top-level alternation such ascat|dogonly anchors one branch, so a value whose first line matches (abc\nanythingagainst[a-z]+) or that merely starts or ends with an alternative passes validation. Compiling as^(?:pattern)$with no flags applies the pattern to the whole value the way the browser does.