Skip to content

♻️ Consolidate external placeholder images to local examples/img (#25045) - #40541

Open
Rishi700252 wants to merge 1 commit into
ampproject:mainfrom
Rishi700252:fix-image-serving-examples
Open

♻️ Consolidate external placeholder images to local examples/img (#25045)#40541
Rishi700252 wants to merge 1 commit into
ampproject:mainfrom
Rishi700252:fix-image-serving-examples

Conversation

@Rishi700252

Copy link
Copy Markdown

This PR is a first step toward consolidating external placeholder images (picsum.photos, placekitten.com) into locally-hosted images already available in examples/img, as tracked in #25045.

Changes

  • examples/amp-story/helloworld.html: replaced picsum.photos image with local examples/img/sea@1x.jpg
  • examples/amp-story/consent.html: replaced placekitten.com publisher logo with local examples/img/ampicon.png
  • examples/amp-story/consent-geo.html: replaced placekitten.com publisher logo with local examples/img/ampicon.png

Verified locally with amp default that all three pages render correctly with the local images.

This is a partial fix — I plan to follow up with additional files referencing external placeholder services in subsequent PRs.

Addresses #25045

@CLAassistant

CLAassistant commented Aug 23, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants