fix(amp-slikeplayer): add amp param to video URL and fullscreen/GDPR support#40521
fix(amp-slikeplayer): add amp param to video URL and fullscreen/GDPR support#40521SlikeTech wants to merge 5 commits into
Conversation
Integrate AMP consent framework so the Slike player iframe can request and receive consent data via postMessage, enabling cleo-player to handle personalisation and analytics decisions based on user consent state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@danielrozenberg looks like bundle size has been running for a day now |
|
Looks like CircleCI hasn't started on this PR at all which is why the bundle size check hasn't started (or finished) - I want to see if closing and reopening this PR will cause it to run CircleCI |
|
@erwinmombay Could you please rerun the CI? The failure doesn't appear to be related to our code changes. |
|
It looks like we had an issue with one of our dependencies. I just fixed it (#40525) but you'll need to rebase this PR on the latest commit in the main branch, lmk if you need help doing that! |
|
Thanks! @danielrozenberg |
|
@SlikeTech do you mind doing the CLA (if you haven't already) |
Summary
Updates the
amp-slikeplayerextension:&=1to the player iframesrcinlayoutCallback()(both default and config code paths) so the player can detect it is running inside an AMP context.postMessagetarget instead of'*'.fullscreenEnter()/fullscreenExit()overrides using#core/dom/fullscreen.amp-slikeplayer.Files
extensions/amp-slikeplayer/0.1/amp-slikeplayer.jsTest
amp=1parameter present in the iframe URL.