Skip to content

✨ Update Neodata amp-analytics vendor config with GDPR support and conditional cookie-match#40520

Open
Ayrton79 wants to merge 2 commits into
ampproject:mainfrom
Ayrton79:SW-1304
Open

✨ Update Neodata amp-analytics vendor config with GDPR support and conditional cookie-match#40520
Ayrton79 wants to merge 2 commits into
ampproject:mainfrom
Ayrton79:SW-1304

Conversation

@Ayrton79

Copy link
Copy Markdown

The Neodata vendor config was missing the gdpr=0|1 flag required by the IAB TCF standard, and cookie-match triggers were always active with no way for publishers to control which partners to enable.

Changes:

  • Add gdpr=0|1 parameter to the pageview URL, derived from CONSENT_METADATA(gdprApplies) via a gdprAppliesFlag variable in the vars section
  • Split the single trackCookieMatch trigger into three separate triggers (trackCmDbm, trackCmAdform, trackCmMediamath), each controlled by a publisher-overridable enableCm* variable that defaults to "" (disabled); publishers opt-in to individual partners from the in-page tag
  • Rename requests ADFORM→cmAdform and MEDIAMATH→cmMediamath for naming consistency with cmDbm
  • Update vendor-requests.json test fixture and examples/analytics-vendors.amp.html accordingly

@CLAassistant

CLAassistant commented Jun 24, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

…nd conditional cookie-match

- Add gdpr=0|1 parameter to pageview URL derived from CONSENT_METADATA(gdprApplies)
- Extract gdprAppliesFlag into vars section to keep the URL readable
- Split trackCookieMatch into three separate triggers (trackCmDbm, trackCmAdform,
  trackCmMediamath), each controlled by an enableCm* var defaulting to "" (disabled),
  so publishers opt-in to individual partners from the in-page tag
- Rename requests ADFORM→cmAdform and MEDIAMATH→cmMediamath for naming consistency
- Update vendor-requests.json fixture and analytics-vendors.amp.html example accordingly
@erwinmombay

Copy link
Copy Markdown
Member

heya @Ayrton79 thanks for the contribution. Are you part of NeoData ?

happy to review this once you can get the tests green

@Ayrton79

Ayrton79 commented Jul 7, 2026

Copy link
Copy Markdown
Author

heya @Ayrton79 thanks for the contribution. Are you part of NeoData ?

happy to review this once you can get the tests green

Hi @erwinmombay , sorry for the late reply.
Yes, I confirm I am part of NeoData as developer and I'm enabled on https://github.com/neodatagroup organization.

About the tests, i'm checking and it seems something related with CircleCI CLI:
gpg: directory '/home/circleci/.gnupg' created
gpg: keybox '/home/circleci/.gnupg/pubring.kbx' created
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0

Exited with code exit status 2

Are these the errors you are referring to?
Do you have any suggestions for resolving them?

Thanks,
Francesco.

@erwinmombay erwinmombay self-assigned this Jul 8, 2026
@erwinmombay

Copy link
Copy Markdown
Member

LGTM. if you could get the CL green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants