Update lua script for mpv based qc view - #1021
Open
privatezero wants to merge 4 commits into
Open
Conversation
Member
|
@privatezero have you ran this with a live source. When I play from tape I get a half second pause in the player every 4 seconds or so |
Member
Author
|
@dericed I'm having some issues on my mac mpv build with it not linking to dependencies correctly to enable Is there a particular view that is triggering that for you, or is it all of them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the qc view lua script to use --lafi-complex for filters and fixes issues with audio scopes and signal stats.
This addresses #847 and #782 and can be built upon for ideas in #989.
Note that for Video + Signal view I dropped the stats being displayed at the bottom of the screen to make things cleaner (and I wasn't sure how to access the main vrecord log path variable from within the lua script since it is assigned externally).