Skip to content

Ruby 3.4.10 address frozen string warning #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsoto111 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Ruby 3.4.10 address frozen string warning #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
991dc23
Fix bundler so dependencies can be installed
Sep 7, 2026
ee36883
Address mini test deprecation warning by using assert_nil if expectin…
Sep 7, 2026
c777ae4
Address future to_s frozen warning raised in mini tests
Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/persistent_open_struct.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ def modifiable
def method_missing(mid, *args) # :nodoc:
mname = mid.id2name
len = args.length
if mname.chomp!('=')
if mname.end_with?('=')
if len != 1
raise ArgumentError, "wrong number of arguments (#{len} for 1)", caller(1)
end
modifiable[new_ostruct_member(mname)] = args[0]
modifiable[new_ostruct_member(mname.chomp('='))] = args[0]
elsif len == 0
@table[mid]
else
Expand Down
3 changes: 1 addition & 2 deletions persistent_open_struct.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]

spec.required_ruby_version = '>= 2.1.0'
spec.add_development_dependency "bundler", "~> 1.6"
spec.add_development_dependency 'rake', '~> 10.4', '>= 10.4.2'
spec.add_development_dependency 'rake', '~> 13.0'
spec.add_development_dependency 'minitest', '~> 5.4', '>= 5.4.3'
spec.add_development_dependency 'benchmark-ips', '~> 2.6'
end
2 changes: 1 addition & 1 deletion test/test_persistent_open_struct.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def test_delete_field
assert_respond_to(o, :foobar)
assert_respond_to(o, :foobar=)
o.delete_field(:foobar)
assert_equal(nil, o.foobar)
assert_nil(o.foobar)
assert_respond_to(o, :foobar)
assert_respond_to(o, :foobar=)
end
Expand Down