AuthAnnonymous: add SASL compliance #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dbus specification states that its authentication mechanism is a SASL profile. Unless (empty) data is provided with the mechanism right away (i.e. `AUTH ANONYMOUS `), SASL compliant authentication responds with a `DATA` message. While some dbus implementations do not do this, the sd-bus does as of systemd >=v242-rc1 [0]. This fixes the response in a backward compatible way by sending back an empty `DATA` message. [0] systemd/systemd@2010873
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dbus specification states that its authentication mechanism is a SASL profile.
Unless (empty) data is provided with the mechanism right away (i.e.
AUTH ANONYMOUS),SASL compliant authentication responds with a
DATAmessage.While some dbus implementations do not do this, the sd-bus does as of systemd >=v242-rc1 [0].
This fixes the response in a backward compatible way by sending back an empty
DATAmessage.[0] systemd/systemd@2010873