Use config gem to manage settings for the end to end tests #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdebrux
force-pushed
the
ldeb-add-config
branch
from
75c7cf3 to
99cad75
Compare
stephencdaly
previously approved these changes
Jan 5, 2026
lfdebrux
force-pushed
the
ldeb-add-config
branch
2 times, most recently
from
05fdca2 to
a826aad
Compare
stephencdaly
reviewed
Jan 7, 2026
There is no longer code in our tests for the Auth0 passwordless connection, so the `USE_AUTH0_PASSWORDLESS_CONNECTION` envvar does nothing. This commit updates our README to reflect this.
Add an environment variable with the name of the AWS environment the end to end tests are being run against. The name of the environment variable is based on that set for our apps in the forms-deploy repo. Nothing in our end to end tests themselves use this currently, but it will become more useful later on.
This is the same gem we use to configure our apps. https://github.com/rubyconfig/config
Add the files required to use the config gem (mostly copied from our Rails apps), plus the code to load the gem and settings into the tests, along with scaffolding/default settings. The default environment is called "development", to align with the development environment/settings in our Rails apps. This refers to a developer environment with apps running locally, rather than the "dev" environment in AWS.
This commit can be reverted once we've updated code that runs the end to end tests to use the new environment variables.
lfdebrux
force-pushed
the
ldeb-add-config
branch
from
a826aad to
528e03c
Compare
stephencdaly
approved these changes
Jan 7, 2026
lfdebrux
added a commit
to alphagov/forms-deploy
that referenced
this pull request
Jan 8, 2026
…e tests The end to end and smoke tests in forms-e2e-tests now use the config gem for configuring parameters and secrets, same as our other apps (see PR alphagov/forms-e2e-tests#213). This has resulted in a change of the names for the environment variables. The configuration is mostly backwards compatible, but it would be good to use the new environment variable names in our Terraform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Currently setting secrets and configuration variables for the end to end tests is very different to how its done for our apps. I find this a little confusing, and it also makes some things harder that they would be for our apps; for instance, there isn't a consistent way to set defaults in files, or have local overrides.
This PR attempts to make the end to end tests more similar to our apps in the way they're configured. We do this by adding the config gem (same as we use in our apps), and renaming settings so that the names are the same or consistent with the names for settings in our apps.
Note that this PR doesn't change all environment variables that the end to end tests use: things like setting the log level are set outside the config gem in our apps, so it felt natural to do the same here; and the functionality to skip certain parts of the tests feels like it doesn't really belong in environment variables/settings at all, so I've left that as is for now.
Things to consider when reviewing