Enhancement: Configurable path prefix and root redirect #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes almarklein#549 This allows administrators to customize the URL path prefix where the TimeTagger instance is served. The default remains `/timetagger/`, for full backward compatibility.
Complementary to almarklein#549 This allows direct redirects from the root path `/` to the main application, bypassing the landing page. This can be useful for self-hosted instances where the landing page is not needed. Note: The landing page remains accessible, when accessed explicitly via `/timetagger/`. (or the configured path prefix)
PassionateBytes
force-pushed
the
feat/549-configurable-path-prefix
branch
from
5b38553 to
ce9a5e0
Compare
Contributor
Author
|
Hey @almarklein! Any thoughts or feedback on this? Would love to get this one merged and released, or at least haar Sinne feedback. |
Owner
|
Sorry for the late review, I've been rather busy lately. |
Owner
|
Looking good, thanks! |
Contributor
Author
|
No problem, and I appreciate the review and merge! 🙏 Will you be kicking off a new release soon? |
Owner
|
I just made a new release. |
Contributor
Author
|
Awesome, thanks mate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new configuration parameters that provide greater flexibility when self-hosting TimeTagger, particularly for deployments behind reverse proxies.
New Parameter:
path_prefixBy default, TimeTagger serves all endpoints at
/timetagger/.... This path prefix can now be configured to custom values.Usage:
/timetagger/, ensuring that the app's behavior remains backward compatible./to effectively disable it altogether./.New Parameter:
app_redirectBy default, TimeTagger redirects requests at the path
/to an informative landing page. This behavior can now be reconfigured, to redirect directly to the application page instead.Usage:
Testing
Comprehensive test coverage has been added to validate:
path_prefixvalues (default, custom paths, root path)app_redirectfunctionality with different path prefixesinvoke tests # succeeds.