-
-
Notifications
You must be signed in to change notification settings - Fork 40
chore(deps): update dependency python to v3.14.0 #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[warning] line too long (339 > 185 characters) (line-length)
Line 35 in 882ba08
| any: ${{ steps.python_changes.outputs.any_changed == 'true' || steps.markdown_changes.outputs.any_changed == 'true' || steps.shell_changes.outputs.any_changed == 'true' || steps.workflow_changes.outputs.any_changed == 'true' || steps.docker_changes.outputs.any_changed == 'true' || steps.yaml_changes.outputs.any_changed == 'true' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[warning] line too long (252 > 185 characters) (line-length)
tux/.github/workflows/docs.yml
Line 210 in 882ba08
| npx wrangler@4 versions deploy "${{ steps.preview_upload.outputs.version_id }}" -y --config wrangler.toml --env preview --message="Preview: tux@${{ github.sha }} on ${{ github.ref_name }} by ${{ github.actor }} (run ${{ github.run_number }})" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[yamllint] reported by reviewdog 🐶
[warning] line too long (348 > 185 characters) (line-length)
tux/.github/workflows/docs.yml
Line 256 in 882ba08
| | Preview | ${{ steps.prepare_url.outputs.is_url == 'true' && format('[{0}]({0})', steps.prepare_url.outputs.preview_url) || steps.prepare_url.outputs.preview_url }} | ${{ steps.preview_upload.outputs.version_id || '-' }} | Preview: tux@${{ github.sha }} on ${{ github.ref_name }} by ${{ github.actor }} (run ${{ github.run_number }}) | |
| @@ -1,4 +1,4 @@ | |||
| FROM python:3.13.8-slim AS base | |||
| FROM python:3.14.0-slim@sha256:0aecac02dc3d4c5dbb024b753af084cafe41f5416e02193f1ce345d671ec966e AS base | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Python version 3.14.0 in Containerfile conflicts with requires-python constraint in pyproject.toml.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The Containerfile has been updated to use python:3.14.0-slim, but the pyproject.toml file specifies requires-python = ">=3.13.2,<3.14". This constraint explicitly forbids Python 3.14.0. When uv sync commands are executed during the Docker build (e.g., on lines 93, 111, 116 of the Containerfile), uv will detect that the running Python version (3.14.0) violates the <3.14 constraint. This will cause uv to raise an error and stop execution, leading to a Docker build failure and preventing the application from being deployed.
💡 Suggested Fix
Update the requires-python constraint in pyproject.toml to allow Python 3.14 (e.g., >=3.13.2,<3.15 or >=3.13.2). Also, update basedpyright's pythonVersion and ruff's target-version to 3.14 to match the runtime.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: Containerfile#L1
Potential issue: The `Containerfile` has been updated to use `python:3.14.0-slim`, but
the `pyproject.toml` file specifies `requires-python = ">=3.13.2,<3.14"`. This
constraint explicitly forbids Python 3.14.0. When `uv sync` commands are executed during
the Docker build (e.g., on lines 93, 111, 116 of the `Containerfile`), `uv` will detect
that the running Python version (3.14.0) violates the `<3.14` constraint. This will
cause `uv` to raise an error and stop execution, leading to a Docker build failure and
preventing the application from being deployed.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 5242425
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1092 +/- ##
=======================================
Coverage 40.13% 40.13%
=======================================
Files 205 205
Lines 14628 14628
Branches 1722 1722
=======================================
Hits 5871 5871
Misses 8757 8757 ☔ View full report in Codecov by Sentry. |
882ba08 to
68a4a1c
Compare
| datasource | package | from | to | | -------------- | ------- | ------ | ------ | | python-version | python | 3.13.8 | 3.14.0 | | docker | python | 3.13.8 | 3.14.0 |
68a4a1c to
e4c43ad
Compare
This PR contains the following updates:
3.13.8->3.14.03.14.13.13.8-slim->3.14.0-slim3.14.1-slim3.13.8-slim->3.14.0-slim3.14.1-slimRelease Notes
python/cpython (python)
v3.14.0Compare Source
v3.13.10Compare Source
v3.13.9Compare Source
Configuration
📅 Schedule: Branch creation - "before 4am on Monday" in timezone America/New_York, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.