You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are outstanding issues relating to extension loading / reloading. The feature is trivialized by meta reload - which is perfectly fine for iterating in development.
Existing extensions will need to be recompiled. Might be a good time for it considering recent V10 version. We can't simply stub everything out like I thought previously since third party plugins copied from our example would disregard UnloadExtension()'s return value. Leading to CExtension holding a dangling m_pAPI
AI Disclosure: Used an LLM to workshop, help find references in code, as well as update any documentation that needed changing.
Kudos on the AI disclosure. But unless I missed something, MMS doesn't have a meta reload command. There's meta retry but iirc this command is only for plugins that failed an initial load. So at the moment reloading sourcemod would involve
meta unload X meta load sourcemod
Perhaps adding a command to unload sourcemod would be nice to have instead ? Metamod takes an ID to unload sourcemod, and I can sense this would become annoying during dev cycles.
sm unload meta load sourcemod
would work out well, instead of having to find the ID of sourcemod through meta list, some sm extensions can bump the plugin ID numbers as well, so there's no reliable well to guess the ID other than checking. So I would introduce that command
Heh I saw a meta reload mentioned somewhere, can't say I actually checked! Yeah we'll definitely need to make that thanks for the note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are outstanding issues relating to extension loading / reloading. The feature is trivialized by
meta reload- which is perfectly fine for iterating in development.Existing extensions will need to be recompiled. Might be a good time for it considering recent V10 version. We can't simply stub everything out like I thought previously since third party plugins copied from our example would disregard
UnloadExtension()'s return value. Leading to CExtension holding a dangling m_pAPIAI Disclosure: Used an LLM to workshop, help find references in code, as well as update any documentation that needed changing.