CI: Fix hl2sdk-mock test error detection - #2558
Open
peace-maker wants to merge 5 commits into
Open
Conversation
The test_format script requires it.
%T expects a client index and translation phrase as arguments, the test was passing a language id and a phrase. It never ran due to sdktools missing on the mock srcds before.
When sourcemod wouldn't even load the tests were still green since there was no "FAIL" in the output :D
peace-maker
force-pushed
the
mock_test_cleanup
branch
from
September 2, 2026 13:25
3a3f340 to
989b6f0
Compare
Use `ParamToArrayPtr()` for direct-array native parameters so nested flat arrays are not misinterpreted as `SpArray` objects.
Member
Author
Member
Author
|
The SP crash was fixed in #2567 as well which was merged earlier. So this is good to notice further problems directly. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests silently did not run at all. When SourceMod wouldn't even load the tests were still green since there was no "FAIL" in the output 😄
Lets run the tests on x86 as well as x86_64 to see if there are differences in the 64bit support.
Fixes #2480