feat(refine): support configurable flat storage types - #677
Open
luoxiaojian wants to merge 1 commit into
Open
Conversation
luoxiaojian
requested review from
Cuiyus,
chinaux,
iaojnh,
richyreachy and
zhourrr
as code owners
August 13, 2026 11:55
luoxiaojian
force-pushed
the
codex/refine-flat-dtype
branch
3 times, most recently
from
August 14, 2026 11:28
e0770ff to
6327e92
Compare
Allow HNSW and Vamana refine Flat indexes to store FP32, FP16, or UINT8 vectors, with raw distance and conversion kernel dispatch. Add an optional hugepage-backed contiguous Flat entity aligned with graph entity dispatch, while preserving mmap fallback for writes and buffer-pool storage.
luoxiaojian
force-pushed
the
codex/refine-flat-dtype
branch
from
August 14, 2026 12:57
6327e92 to
bc33654
Compare
iaojnh
reviewed
Aug 18, 2026
| int FlatContiguousStreamerEntity::add_vector_with_id(uint32_t id, | ||
| const void *query, | ||
| uint32_t element_size) { | ||
| degrade_to_mmap(); |
Collaborator
There was a problem hiding this comment.
这里需不需要考虑add和search的并发问题？比如正常用连续内存search的时候来了个add，清空了连续内存，search就会访问到空指针。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.