refactor: use std::filesystem to refactor file_helper to support utf8 path on Windows #359
Open
JalinWang wants to merge 14 commits intoalibaba:mainfrom
Open
refactor: use std::filesystem to refactor file_helper to support utf8 path on Windows #359JalinWang wants to merge 14 commits intoalibaba:mainfrom
JalinWang wants to merge 14 commits intoalibaba:mainfrom
Conversation
zhourrr
reviewed
Apr 21, 2026
| set(WITH_TOOLS OFF CACHE BOOL "build with tools" FORCE) | ||
| set(WITH_LZ4 ON CACHE BOOL "build with lz4" FORCE) | ||
| set(USE_RTTI ON CACHE BOOL "build with RTTI" FORCE) | ||
| set(WITH_WINDOWS_UTF8_FILENAMES ON CACHE BOOL "use UTF8 as characterset for opening files, regardles of the system code page" FORCE) |
Collaborator
There was a problem hiding this comment.
"regardless",这个会导致已有的文件打不开吗？感觉上应该不会造成问题
Collaborator
Author
There was a problem hiding this comment.
不会，这样表明内部传递的字符串都是utf8，而不是默认的需要由code page决定的编码的字符串
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.