Skip to content

test: add test_collection_ddl cases#314

Open
liututu12 wants to merge 6 commits intoalibaba:mainfrom
liututu12:test/test_ddl
Open

test: add test_collection_ddl cases#314
liututu12 wants to merge 6 commits intoalibaba:mainfrom
liututu12:test/test_ddl

Conversation

@liututu12
Copy link
Copy Markdown
Collaborator

@liututu12 liututu12 commented Apr 3, 2026 

1.Create index functionality to supplement support for all data types, index methods, and metric combinations, as well as       unsupported scenarios;
2.Supplement test cases for the collection.optimize method;
3.After any DDL operation (creating an index, adding/modifying/deleting a column, collection.flush(), optimize(),
etc.), close the collection, reopen it, and write data to check if this process works correctly.

@liututu12 liututu12 requested a review from zhourrr April 3, 2026 09:35
@liututu12 liututu12 self-assigned this Apr 3, 2026
@liututu12 liututu12 requested a review from Cuiyus as a code owner April 3, 2026 09:35
greptile-apps[bot]
greptile-apps Bot reviewed Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@zhourrr zhourrr added the deferred valid issue but not prioritized for current milestone. Planned for future release. label Apr 20, 2026
feihongxu0824
feihongxu0824 reviewed Apr 23, 2026
View reviewed changes
Comment thread python/tests/detail/params_helper.py
FlatIndexParam(),
FlatIndexParam(metric_type=MetricType.IP, quantize_type=QuantizeType.INT4),
FlatIndexParam(metric_type=MetricType.L2, quantize_type=QuantizeType.INT8),
FlatIndexParam(metric_type=MetricType.COSINE, quantize_type=QuantizeType.FP16),
Copy link
Copy Markdown
Collaborator

@feihongxu0824 feihongxu0824 Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this case?

Comment thread python/tests/detail/test_collection_ddl.py
from params_helper import *
import threading, time

indextest_collection_schema = zvec.CollectionSchema(
Copy link
Copy Markdown
Collaborator

@feihongxu0824 feihongxu0824 Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use full_schema in fixture_helper?

Comment thread python/tests/detail/test_collection_ddl.py
)


def batchdoc_and_check(collection: Collection, multiple_docs, operator="insert"):
Copy link
Copy Markdown
Collaborator

@feihongxu0824 feihongxu0824 Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there so many places with batchdoc_and_check? Why not unify them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feihongxu0824 feihongxu0824 feihongxu0824 left review comments

@zhourrr zhourrr Awaiting requested review from zhourrr

@Cuiyus Cuiyus Awaiting requested review from Cuiyus Cuiyus is a code owner

+1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@liututu12 liututu12

Labels

deferred valid issue but not prioritized for current milestone. Planned for future release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liututu12 @feihongxu0824 @zhourrr @iaojnh @JalinWang