feat: add flexible dependency source resolution#259
Open
suxiaogang223 wants to merge 9 commits intoalibaba:mainfrom
Open
feat: add flexible dependency source resolution#259suxiaogang223 wants to merge 9 commits intoalibaba:mainfrom
suxiaogang223 wants to merge 9 commits intoalibaba:mainfrom
Conversation
2b78054 to
bfd2720
Compare
Contributor
Author
|
@zjw1111 Hi, could you help review this PR when you have time? This PR now focuses on flexible dependency source resolution and the sanitizer CI issue has been fixed in the latest commit. The remaining follow-up work and broader design discussion will be tracked in #260, so we can keep this PR scoped and easier to review. Thanks.🤓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #103
This PR introduces a flexible dependency source resolution interface for selected third-party dependencies.
It adds:
PAIMON_DEPENDENCY_SOURCE=AUTO|BUNDLED|SYSTEM*_SOURCEoverridesPAIMON_PACKAGE_PREFIXFindXxxAlt.cmakemodulesPackage-manager-specific modes are intentionally left out of this first PR and should be discussed separately.
Tests
Fedora:
cmake -S . -B build-scope-bundled -DPAIMON_DEPENDENCY_SOURCE=BUNDLEDcmake --build build-scope-bundled -j$(nproc)cmake -S . -B build-scope-auto -DPAIMON_DEPENDENCY_SOURCE=AUTOcmake --build build-scope-auto -j$(nproc)cmake -S . -B build-scope-tests -DPAIMON_DEPENDENCY_SOURCE=BUNDLED -DPAIMON_BUILD_TESTS=ONcmake --build build-scope-tests --target paimon-tests -j$(nproc)Also verified invalid dependency source values are rejected by configure-time validation.
API and Format
No storage format or public C++ API changes.
Documentation
Updated README and building docs for dependency source configuration.
Generative AI tooling
Generated-by: OpenAI Codex