-
Notifications
You must be signed in to change notification settings - Fork 45
feat: optimize parquet reads with bucket and page-level filtering #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
liangjie3138
wants to merge
16
commits into
alibaba:main
Choose a base branch
from
liangjie3138:dev_parquet
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4a249b9
introduce parquet page filter
liangjie3138 434dd99
page level prebuffer
liangjie3138 5118f9e
remove trace
liangjie3138 63b5f1c
BucketSelectConverter support timestamp tyope & add ut
liangjie3138 27277b0
fix SetupCxxFlags.cmake
liangjie3138 efc80b1
Merge remote-tracking branch 'origin/main' into dev_parquet
liangjie3138 d889f1d
fix code style
liangjie3138 c729b3b
Merge branch 'main' into dev_parquet
liangjie3138 6343a61
remove bucket selector
liangjie3138 90a42fc
fix review
liangjie3138 d6a8499
add itcase
liangjie3138 1e93976
Merge remote-tracking branch 'origin/main' into dev_parquet
liangjie3138 5078e1f
fix bucket
liangjie3138 246ea68
fix style
liangjie3138 9521467
Merge branch 'main' into dev_parquet
liangjie3138 318f1b8
Merge branch 'main' into dev_parquet
lucasfang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious — is this issue introduced by the page-level pushdown feature, or did it exist before?
If it's a pre-existing problem, should we consider submitting a separate fix PR to address it independently?
That way, we can clearly track and verify the bug fix without being coupled to the new feature changes.