fix: correct path references in batch_convert_html.sh#39
Open
handsomesix wants to merge 1 commit into
Open
Conversation
The script was using incorrect relative paths after changing to the scripts/ directory. Fixed: - Changed initial cd from SCRIPT_DIR/../ to SCRIPT_DIR/../../ to reach project root - Updated converter script paths from ./converters/ to ../tools/converters/ - Moved directory existence checks before cd to scripts/ Fixes alibaba#38
1754832 to
b5eec34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
make doccommand execution failure. Adjust the directory switching and script reference logic inbatch_convert_html.shto ensure the documentation conversion script runs from the correct path.Root Cause
batch_convert_html.shhas multiple path handling issues:SCRIPT_DIR/../, which enters thetools/directory instead of the project root../converters/, but that path doesn't exist in the current working directory.scripts/directory, causing path judgment based on the wrong working directory.These issues collectively prevent
make docfrom correctly locating the conversion scripts and documentation directories.Changes
SCRIPT_DIR/../toSCRIPT_DIR/../../to ensure entering the project root../converters/to../tools/converters/.scripts/directory to avoid path judgment issues caused by working directory changes.Tests
make docto verify the script workflow.Risk
Low.
Only modified the path handling logic in the documentation build script, no runtime code or model functionality changes.