Bump d3-color from 2.0.0 to 3.1.0 with package-lock.json#6
Open
Joshnovski wants to merge 1 commit intoalgrx:masterfrom
Open
Bump d3-color from 2.0.0 to 3.1.0 with package-lock.json#6Joshnovski wants to merge 1 commit intoalgrx:masterfrom
Joshnovski wants to merge 1 commit intoalgrx:masterfrom
Conversation
Author
|
Let me know what you think when you get time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
npm i d3-colorupdated the structure of package-lock.json as well. I discovered that this was because I was using a recent version of npm and node.js. To remedy this, I rolled my npm and node to versions compatible with the structure you have for package-lock.json, i.e. (npm 6.7.0 and node 11.15.0). This resulted in far smaller update changes in package-lock.json.I want to note that, although I have updated d3-color, d3-interpolate and d3-transition still wants to use d3-color 2.0.0. You will see in the change log that it is bound to versions "1-2".
On a side note, the fix I have currently implemented in my own project to overcome the current d3-color vulnerability is adding this override (I included dependencies for context);
At the bottom of my package.json file. With this override + running
npm iI am not getting vulnerability flags on my end.