Repository navigation
Conversation
feed() only ends a sentence when punctuation is followed by whitespace, so a normally stopped reply such as "Wait, check the units." stayed pending and no hint was injected. Flush that trailing sentence only when the segment finishes normally. Signed-off-by: Ting Zhang <181050363+GPT-AGI@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On current
main, this stopped completion returns with no hint and does not continue:StreamingHintRetriever.feedcloses punctuation only when whitespace follows, so the final uncertain sentence stays pending.A normal
stopnow flushes that sentence through the existing gap, uncertainty, and threshold rules. Length/full-budget truncation and other finish reasons do not flush; a regression test preserves3.+14across segments.Verified with Python 3.12 and the CI dependency set:
python -m pytest tests/test_streaming_hints.py tests/test_plugins.py tests/test_plugin_gating.py -q(48 passed).