Repository navigation
Conversation
The example config falls back with ${OPENAI_API_KEY_2:-${OPENAI_API_KEY}}.
The old scanner stopped at the first closing brace, so an unset secondary key
stayed as the literal ${OPENAI_API_KEY} and a set key kept a trailing }.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optillm/plugins/proxy/example_config.yamldocuments:With
OPENAI_API_KEY=sk-primary, this returned the literal${OPENAI_API_KEY}when the secondary key was unset, orsk-secondary}when it was set.The interpolation regex stopped at the inner closing brace. It now recognizes the documented nested-default form before the existing simple form, while preserving simple variables, literal defaults, unknown variables, and environment values verbatim.
Verified on Windows with Python 3.12 after installing the same requirements as CI:
TestProxyEnvInterpolationpasses (3 tests), andtests/test_proxy_plugin.pypasses in full (12 tests).