Repository navigation
fix(config): export rules and synonyms in index config export - #297
Merged
Merged
Conversation
The BrowseRules/BrowseSynonyms aggregator receives a pointer to the response, but the helpers asserted the value type and silently dropped every page. Rules and synonyms were never exported, and scopes limited to them failed with 'No config to export'. Co-authored-by: Cursor <cursoragent@cursor.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
8bittitan
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
algolia index config exportnever included rules or synonyms, and--scope rules/--scope synonymson their own failed withNo config to export.GetRulesandGetSynonymscollect results through the API client'sBrowseRules/BrowseSynonymsaggregator. The client passes the aggregator a pointer to the response (*SearchRulesResponse), but the helpers asserted the value type and discarded the failed assertion, so every page was silently dropped.rules browseandsynonyms browsealready use the pointer type, which is why they worked.Changes
*search.SearchRulesResponse/*search.SearchSynonymsResponseand skip nil responses (the aggregator is also called with a nil response on request failure).config_test.gocoveringGetIndexConfigfor all scopes, rules only, and synonyms only. These fail onmainand pass with the fix.Fixes #190
Made with Cursor