Open
Conversation
Fluf22
reviewed
Feb 18, 2026
Comment on lines
+7
to
+9
| const g: any = typeof globalThis !== 'undefined' ? globalThis : undefined; | ||
|
|
||
| if (g && g.scheduler && g.scheduler.yield) { |
Contributor
There was a problem hiding this comment.
Why not directly
Suggested change
| const g: any = typeof globalThis !== 'undefined' ? globalThis : undefined; | |
| if (g && g.scheduler && g.scheduler.yield) { | |
| if (typeof globalThis !== 'undefined' && globalThis && globalThis.scheduler && globalThis.scheduler.yield) { |
Fluf22
reviewed
Feb 18, 2026
| const isExpired = cacheItem.timestamp + timeToLive < currentTimestamp; | ||
|
|
||
| return !isExpired; | ||
| return cacheItem.timestamp + timeToLive >= new Date().getTime(); |
Contributor
There was a problem hiding this comment.
Do you think we could extract new Date().getTime() outside of the filter loop?
So it's computed once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces localStorage blocking in
createBrowserLocalStorageCacheto improve INP by merging two filter passes into one (cuttingget()from 2 reads + 2 writes to 1 read + 1 write) and yielding to the main thread viascheduler.yield()/setTimeoutbefore heavy work inget(),set(), anddelete().