test: stabilize WolfSSL early-loss interop case#141
Merged
algesten merged 1 commit intoMay 31, 2026
Conversation
Owner
|
Nice thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps the WolfSSL DTLS 1.3 early packet-loss interop test on the original three dropped server packets, but makes the harness ordering deterministic.
The test was calling
handle_timeout(now)again immediately after delivering fresh WolfSSL client packets to the dimpl server, before draining the server output generated by that input. That can race retransmit output with the newly processed client flight and make WolfSSL fail to observe connection completion.This changes the test to drain fresh server output before processing another timeout tick. No protocol behavior is changed.
This is not known to affect current upstream CI: the GitHub Actions matrix builds the
rcgenfeature, but only runs tests foraws-lc-rsandrust-crypto, so this WolfSSL interop case is mainly hit by local fullrcgenvalidation.It matters because
cargo test --all-targets --features rcgenis the natural local "run everything" command for this repo, and this test can fail nondeterministically there even when the protocol code is unchanged.Validation:
cargo fmt --checkgit diff --checkgit diff --check upstream/main...HEADcheck-snowflake-local.pl upstream/maincargo test --test dtls13 wolfssl::dtls13_wolfssl_server_handshake_with_early_packet_loss --features rcgen -- --exactcargo test --all-targets --features rcgencargo clippy --all-targets --features rcgen -- -D warningscargo test --no-default-features --features rust-cryptocargo clippy --no-default-features --features rust-crypto -- -D warningscargo test --doc --features rcgen