test: pin raw render_markdown invocations to the pipeline allowlist#220
Open
PathGao wants to merge 1 commit into
Open
test: pin raw render_markdown invocations to the pipeline allowlist#220PathGao wants to merge 1 commit into
PathGao wants to merge 1 commit into
Conversation
The preview pipeline (renderMarkdownPreview) strips YAML front matter
before invoking the Rust renderer. The raw invoke('render_markdown')
command is a string RPC, so the type checker cannot flag call sites
that bypass the pipeline — two such bypasses have already slipped
through merges unnoticed. This test pins the exact files (and counts)
allowed to touch the raw command; any new render call site must go
through the pipeline or consciously widen the allowlist.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a source-convention test (same style as the existing script tests) asserting that the raw
invoke('render_markdown')command appears only insiderenderMarkdownPreviewand inutils/export.ts(which strips front matter itself).Why
renderMarkdownPreviewexists so every preview render strips YAML front matter before hitting the Rust renderer (#194). But the raw command is a string RPC — the type checker can't flag a call site that bypasses the wrapper, and a bypass renders the front matter into the body (hr + setext heading). This is not hypothetical: two such bypasses have already slipped through merges silently in downstream branches. This test turns the convention into a red test instead of a code-review memory item.If a future change legitimately needs the raw command, the allowlist in the test is the conscious place to widen it.
Verification
🤖 Generated with Claude Code