Conversation
🦋 Changeset detectedLatest commit: e8058de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis PR adds a patch changeset, introduces Russian i18n entries, duplicates small documentation snippets, updates AutoExpandable to respect print mode, adds overflow: hidden to expandable containers, and refactors global tab and doc-layout selectors in SCSS. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
There was a problem hiding this comment.
Pull request overview
Adjusts Doom/Rspress styling to address container/layout issues (including print layout) and updates fixture docs for i18n/content examples.
Changes:
- Update global tab/codeblock and print-layout styling in
global.scss. - Refine
AutoExpandablestyling/behavior for codeblocks and print mode. - Extend fixture docs i18n and update MDX content examples.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/doom/styles/global.scss | Updates tab/codeblock styling and adjusts print layout rules (hide outline/sidebar; reset doc max-width/padding). |
| packages/doom/styles/auto-expandable.module.scss | Ensures bordered codeblock containers clip to rounded corners via overflow: hidden. |
| packages/doom/src/theme/AutoExpandable.tsx | Skips auto-collapse detection during print via useIsPrint. |
| fixture-docs/i18n.json | Adds Russian (ru) translations for fixture keys. |
| fixture-docs/en/index.mdx | Expands fixture tab content with additional Markdown/codeblock examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@fixture-docs/en/index.mdx`:
- Around line 57-59: The MDX code block for the AcpApisOverview component is not
properly fenced which triggers remark-lint-code-block-split-list; wrap the
component inside a fenced MDX code block by adding the opening and closing
triple backticks and the language/title marker so the snippet reads ```mdx
title="AcpApisOverview" on the opening line, include the <AcpApisOverview />
component on the next line, and then close with ``` on the following line to
ensure the block is correctly recognized.
- Around line 41-43: The code fence after the list is not indented, causing
remark-lint-code-block-split-list to treat it as a split; indent the entire code
block (the ```mdx title="AcpApisOverview" fence, its contents including
<AcpApisOverview />, and the closing ```) by two spaces so it is aligned as a
list continuation (i.e., prefix each of those three lines with two spaces).
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.changeset/old-cooks-rule.mdfixture-docs/en/index.mdxfixture-docs/i18n.jsonpackages/doom/src/theme/AutoExpandable.tsxpackages/doom/styles/auto-expandable.module.scsspackages/doom/styles/global.scss
close DOC-107
JounQin
force-pushed
the
fix/known_ui_issues
branch
from
d272b0c to
e8058de
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (2)
fixture-docs/en/index.mdx (2)
41-43: Verify that the{/* lint ignore */}comment with a blank separator correctly suppresses the CI failure.remark-lint officially supports MDX comments for rule suppression when
remark-mdxis used:{/* lint ignore rule-name */}, so the syntax is correct. However, the docs note you'll typically need blank lines between HTML comments and other constructs — for MDX JSX expression comments the blank line at line 42 may affect which AST node theignoredirective targets. If the blank line causes the parser to treat the code fence as a non-adjacent sibling rather than the immediately following node, the suppression will silently fail and CI will still error. Please confirm CI passes with this approach rather than the previously suggested 2-space indentation.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@fixture-docs/en/index.mdx` around lines 41 - 43, The MDX suppression comment `{/* lint ignore code-block-split-list */}` is separated from the fenced code block (```mdx title="AcpApisOverview"`) by a blank line which can prevent the ignore directive from targeting the fence; move the `{/* lint ignore code-block-split-list */}` comment so it is immediately adjacent above the ```mdx title="AcpApisOverview" fence with no blank line between them (i.e., place the comment directly on the line immediately before the opening backticks) and re-run CI to confirm the rule is suppressed.
59-63: Same lint-ignore-with-blank-line pattern as lines 41–43 — same verification needed.This mirrors the pattern at lines 41–43. If the blank line at 60 causes the
{/* lint ignore code-block-split-list */}comment to miss the following code fence in the AST, CI will still fail here as well. Both suppressions should be validated together in CI.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@fixture-docs/en/index.mdx` around lines 59 - 63, The lint suppression comment {/* lint ignore code-block-split-list */} is separated from the following MDX code fence for the AcpApisOverview example (<AcpApisOverview />) by a blank line which can cause the suppression to miss the fence in the AST; fix this by removing the blank line so the comment directly precedes the fenced block (make it identical to the earlier working pattern), and also add/adjust the CI/test that verifies the suppression for this specific pattern (the comment + ```mdx title="AcpApisOverview" ... <AcpApisOverview />) so both occurrences are validated together.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@fixture-docs/en/index.mdx`:
- Around line 41-43: The MDX suppression comment `{/* lint ignore
code-block-split-list */}` is separated from the fenced code block (```mdx
title="AcpApisOverview"`) by a blank line which can prevent the ignore directive
from targeting the fence; move the `{/* lint ignore code-block-split-list */}`
comment so it is immediately adjacent above the ```mdx title="AcpApisOverview"
fence with no blank line between them (i.e., place the comment directly on the
line immediately before the opening backticks) and re-run CI to confirm the rule
is suppressed.
- Around line 59-63: The lint suppression comment {/* lint ignore
code-block-split-list */} is separated from the following MDX code fence for the
AcpApisOverview example (<AcpApisOverview />) by a blank line which can cause
the suppression to miss the fence in the AST; fix this by removing the blank
line so the comment directly precedes the fenced block (make it identical to the
earlier working pattern), and also add/adjust the CI/test that verifies the
suppression for this specific pattern (the comment + ```mdx
title="AcpApisOverview" ... <AcpApisOverview />) so both occurrences are
validated together.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.changeset/old-cooks-rule.mdfixture-docs/en/index.mdxfixture-docs/i18n.jsonpackages/doom/src/theme/AutoExpandable.tsxpackages/doom/styles/auto-expandable.module.scsspackages/doom/styles/global.scss
🚧 Files skipped from review as they are similar to previous changes (4)
- .changeset/old-cooks-rule.md
- packages/doom/styles/global.scss
- packages/doom/styles/auto-expandable.module.scss
- packages/doom/src/theme/AutoExpandable.tsx
close DOC-107
Summary by CodeRabbit
Bug Fixes
Documentation
Localization
Improvements
Style