chore(low-code): remove unused SubstreamPartitionRouter._migrate_child_state_to_parent_state - #1100
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe substream partition router removes ChangesState handling
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@lazebnyi/remove-dead-migrate-child-state#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch lazebnyi/remove-dead-migrate-child-statePR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
What
Remove
SubstreamPartitionRouter._migrate_child_state_to_parent_state— it has no callers anywhere in the codebase.Why
It's dead code left over from the pre-concurrent implementation: parent state is now seeded at stream-construction time in
ModelToComponentFactory._instantiate_parent_stream_state_manager. Leaving it around is misleading — the analysis in #1067 anchored on it as a suspected root cause, and #1079 independently noted it has no callers.Test
grep -rn _migrate_child_state_to_parent_state— no remaining references (production or tests)pytest unit_tests/sources/declarative/partition_routers/— 68 passedSummary by CodeRabbit