fix(file-based): populate failure_type, internal_message, and exception on CSV encoding error#1053
Draft
devin-ai-integration[bot] wants to merge 1 commit into
Draft
Conversation
…on on CSV encoding error The UnicodeError handler in csv_parser.py raised AirbyteTracedException without failure_type, internal_message, or exception parameters. This caused Sentry to title the event 'AirbyteTracedException: None' and classified the error as system_error instead of config_error. - Capture the UnicodeError as 'e' - Set failure_type=FailureType.config_error - Set internal_message=str(e) for Sentry grouping - Set exception=e to preserve the original stack trace - Improve user-facing message per error message guidelines Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1781539607-fix-csv-unicode-error-handling#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1781539607-fix-csv-unicode-error-handlingPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
UnicodeErrorhandler incsv_parser.py:read_data()raisedAirbyteTracedExceptionwithoutfailure_type,internal_message, orexceptionparameters. This caused:AirbyteTracedException: None(becauseinternal_messagewasNone)system_errorinstead ofconfig_errorUnicodeErrorstack trace is lostThis follows the same pattern already used elsewhere in the file (lines 178, 186, 212).
Resolves https://github.com/airbytehq/oncall/issues/12517:
Breaking Change Evaluation
Not a breaking change. This is a bug fix that improves error classification and messaging — no schema, spec, stream, or state changes.
Test Coverage
Updated
CsvReaderTest.test_read_data_with_encoding_errorto verify all new fields:failure_type == FailureType.config_error,internal_messagematches the original error string, and_exceptionpreserves the originalUnicodeErrorinstance.Link to Devin session: https://app.devin.ai/sessions/becb680c363a4cecb6664b5fc80b9739