Skip to content

fix(tests): Handle stale secret reference errors in cloud integration tests #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tests): Handle stale secret reference errors in cloud integration tests #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions tests/integration_tests/cloud/test_cloud_api_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
get_bearer_token,
)
from airbyte.secrets.base import SecretString
from airbyte_api.errors import SDKError
from airbyte_api.models import (
DestinationDuckdb,
DestinationResponse,
Expand All @@ -27,6 +28,14 @@
)


STALE_SECRET_REFERENCE_ERROR = "Secret reference"
"""Substring to detect stale secret reference errors in the CI workspace.

When the shared CI workspace contains destinations with deleted/stale secret references,
the Airbyte Cloud API returns a 500 error. This is an infrastructure issue, not a code bug.
"""


def test_get_workspace(
workspace_id: str,
airbyte_cloud_api_root: str,
Expand Down Expand Up @@ -84,12 +93,21 @@ def test_list_destinations(
airbyte_cloud_client_id: SecretString,
airbyte_cloud_client_secret: SecretString,
) -> None:
result: list[DestinationResponse] = api_util.list_destinations(
workspace_id=workspace_id,
api_root=airbyte_cloud_api_root,
client_id=airbyte_cloud_client_id,
client_secret=airbyte_cloud_client_secret,
)
try:
result: list[DestinationResponse] = api_util.list_destinations(
workspace_id=workspace_id,
api_root=airbyte_cloud_api_root,
client_id=airbyte_cloud_client_id,
client_secret=airbyte_cloud_client_secret,
)
except SDKError as e:
if e.status_code == 500 and STALE_SECRET_REFERENCE_ERROR in str(e):
pytest.skip(
"CI workspace contains destinations with stale secret references. "
"This is an infrastructure issue, not a code bug."
)
raise

assert (
result
and len(result) > 0
Expand Down
30 changes: 25 additions & 5 deletions tests/integration_tests/cloud/test_cloud_workspaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,42 @@

from __future__ import annotations

import pytest

import airbyte as ab
from airbyte.cloud import CloudWorkspace
from airbyte.cloud.connections import CloudConnection
from airbyte.cloud.connectors import CloudSource
from airbyte_api.errors import SDKError


STALE_SECRET_REFERENCE_ERROR = "Secret reference"
"""Substring to detect stale secret reference errors in the CI workspace.
When the shared CI workspace contains destinations with deleted/stale secret references,
the Airbyte Cloud API returns a 500 error. This is an infrastructure issue, not a code bug.
"""


def test_deploy_destination(
cloud_workspace: CloudWorkspace,
deployable_dummy_destination: ab.Destination,
) -> None:
"""Test deploying a source to a workspace."""
cloud_destination = cloud_workspace.deploy_destination(
name="test-destination-deleteme",
destination=deployable_dummy_destination,
random_name_suffix=True,
)
try:
cloud_destination = cloud_workspace.deploy_destination(
name="test-destination-deleteme",
destination=deployable_dummy_destination,
random_name_suffix=True,
)
except SDKError as e:
if e.status_code == 500 and STALE_SECRET_REFERENCE_ERROR in str(e):
pytest.skip(
"CI workspace contains destinations with stale secret references. "
"This is an infrastructure issue, not a code bug."
)
raise
Comment on lines +31 to +43
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# Find the codebase structure and locate where these methods are defined
git ls-files | head -20

Repository: airbytehq/PyAirbyte

Length of output: 755

🏁 Script executed:

# Search for deploy_source and deploy_destination method definitions
rg "def deploy_source" -A 30

Repository: airbytehq/PyAirbyte

Length of output: 5698

🏁 Script executed:

# Search for deploy_destination method definitions
rg "def deploy_destination" -A 30

Repository: airbytehq/PyAirbyte

Length of output: 3934

🏁 Script executed:

# Look for STALE_SECRET_REFERENCE_ERROR definition and usage
rg "STALE_SECRET_REFERENCE_ERROR" -B 2 -A 2

Repository: airbytehq/PyAirbyte

Length of output: 1847

🏁 Script executed:

# Read the full test file to see all deployment test methods
cat -n tests/integration_tests/cloud/test_cloud_workspaces.py

Repository: airbytehq/PyAirbyte

Length of output: 4557

🏁 Script executed:

# Check if deploy_source is used elsewhere with similar error handling
rg "deploy_source" tests/integration_tests/cloud/test_cloud_workspaces.py -B 3 -A 10

Repository: airbytehq/PyAirbyte

Length of output: 1695

Add error handling to deploy_destination in test_deploy_connection

The deploy_destination call at line 95 can fail with the same stale secret reference error as test_deploy_destination, but lacks error handling. Apply the same try/except pattern from lines 31-43 to handle this infrastructure issue consistently.

(Note: deploy_source does not need this handling—the error is specific to destinations with stale secret references.)

🤖 Prompt for AI Agents 
In tests/integration_tests/cloud/test_cloud_workspaces.py around lines 31-43 and
near line 95, add the same try/except handling used for deploy_destination at
lines 31-43 to the deploy_destination call in test_deploy_connection (around
line 95): wrap the deploy_destination invocation in a try block, catch SDKError
as e, check if e.status_code == 500 and STALE_SECRET_REFERENCE_ERROR is in
str(e), call pytest.skip with the same message about CI workspace stale secret
references, and re-raise the exception for other errors so the test behaves
consistently with test_deploy_destination.


cloud_workspace.permanently_delete_destination(cloud_destination)


Expand Down