[react] [readme] Fix broken documentation links and syntax error in code example - #3304
Open
mohit-nayak wants to merge 1 commit into
Open
[react] [readme] Fix broken documentation links and syntax error in code example#3304mohit-nayak wants to merge 1 commit into
mohit-nayak wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3303
The React/JSX Style Guide had 3 dead external links and 1 syntax error in a code example.
Broken links
All three
facebook.github.io/reactURLs return 404. React's legacy docs and blog now live atlegacy.reactjs.org.facebook.github.io/react/docs/reusable-components.html#stateless-functionslegacy.reactjs.org/docs/components-and-props.html#function-and-class-componentsfacebook.github.io/react/blog/2016/07/13/mixins-considered-harmful.htmllegacy.reactjs.org/blog/2016/07/13/mixins-considered-harmful.htmlfacebook.github.io/react/blog/2015/12/16/ismounted-antipattern.htmllegacy.reactjs.org/blog/2015/12/16/ismounted-antipattern.htmlA note on line 28: the issue suggested
legacy.reactjs.org/docs/react-without-es6.html, but that page is aboutcreateReactClass, not stateless function components. The oldreusable-components.html#stateless-functionscontent was folded intocomponents-and-props.html, so I pointed at the#function-and-class-componentsanchor there instead, which is what the sentence is actually referring to.All replacements kept on
legacy.reactjs.orgrather thanreact.devfor consistency, since the two blog posts only exist on legacy and the surrounding guide is still written against class-component-era React.Syntax error
The "Spreading objects with known, explicit props" example (line 457) was missing the parameter parentheses, so it would not parse: