Review: Add IKEA WebHarbor mirror (#49) - #77
Open
TabsPhasers wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviews and carries forward #49 by @Lxr-max on top of the current
mainbranch.This PR preserves the original IKEA mirror contribution, resolves its current integration conflicts, implements the code-side catalog-image fix, tracks the required asset delivery in HF Asset PR #49, and completes the deterministic grading contract for all 18 IKEA tasks.
Original review resolution
The original review requested two asset fixes:
ikea.tar.gzand pin the merged asset revision — the asset package has been submitted in HF Asset PR #49. Updating.assets-revisionremains blocked until that PR is merged.Review changes
verifier_pathand non-emptyjudge_rubricfor all 18 tasksinitial.dbandafter.dbdirectly from the standard run directory, keeping IKEA grading self-containedAsset delivery status — blocking
oratory3nikea.tar.gz531368c4967453dbbd842b1a66922113fe1719355958e383e4864c6d96bf7c3bThe archive was audited before upload. Local username/group metadata and macOS provenance attributes were removed. No local paths, credentials, API keys, private keys, EXIF/GPS/XMP metadata, or other sensitive data were found.
This GitHub PR must not merge until:
.assets-revisionis updated to the HF merge commitfetch_assets.sh ikeaScope
success/passchanges are intentionally excluded and preserved on a separate branch for independent review.Validation
verifier_path, andjudge_rubricgit diff --check origin/main..review/pr-49-ikeapassesReviews #49.
Original asset review: #49 (comment)
Review lock: #49 (comment)