docs(design): revise 054 against the tree after 055 - #270
Merged
Merged
Conversation
- Rebase the inbound entry point on 055's router: InboundDispatch::new takes the grammar and returns DbResult; subscriptions() replaces resource_ids(); add the 055 bench rows to the baseline and targets. - Correct the MQTT connector-side copy count (topic copies inbound on both backends) and record the embedded per-packet encode Vec; the embedded outbound design now encodes straight into the write ring. - Specify RoutePublisher flush, shutdown and error attribution; call poll_ready before receiving (Sink order). - Drop the async recv/recv_into instead of promising an adapter. - Native outbound: ReusableBoxFuture vs try_publish, with the default. - G3: the bench is only built in CI today; add the job in step 1. - Note the embedded EventChannel burst-slack behaviour change, Zenoh (053), and new open questions (control-packet space, packet ids). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RADQu7JwhKvSpicW4qzFz8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revises design 054 (zero-allocation connector boundary). The doc was written before 055 landed, and a few of its claims about the MQTT connector didn't match the code. This PR changes only the doc, no code.
Rebased on 055
InboundDispatch::newnow takes a&'static dyn TopicGrammarand returnsDbResult, matchingAimDb::inbound_router.subscriptions()replacesresource_ids().inbound_route_pattern,_keyed_known,_keyed_new) are added to the baseline and target tables. G1 now says "steady state" and excludes the first sighting of a key.MQTT connector: corrected against the code
topic_name.to_string(), nativepublish.topic.clone(). The native clone could simply be a move and is called out as a standalone fix.Vec<u8>per packet insession_loop::encodefor theChannel<Vec<u8>, 4>write queue. The byte ring in §4.6 didn't remove that, so "allocation-free MQTT path" was false. The embedded design now encodes PUBLISH packets straight into a write ring that replaces the channel.ReusableBoxFuture(the default, keeps backpressure) ortry_publish(errors reported immediately, no readiness signal).RoutePublishersemanticspoll_flush, a flush on shutdown, and explicit error attribution for asynchronous hand-over (an error surfaces one message late).poll_readybefore receiving, the usualSinkorder.Other
recv/recv_intoinstead of promising an adapter. The only implementors are in this repo.b0_alloc_connectortoday and never runs it. A CI job that runs it is added in migration step 1.EventChannelstops absorbing bursts once ingest callsdispatchdirectly.heaplessaction channel), and new open questions (reserved ring space for control packets, packet-id reservation).Related Issue
Checklist
make check). (not run; no code changes)🤖 Generated with Claude Code
https://claude.ai/code/session_01RADQu7JwhKvSpicW4qzFz8
Generated by Claude Code