vrefactor: use standard Pino API for logging #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
charlypa
commented
Oct 19, 2025
charlypa
commented
- Remove messageKey config from logger (fixes pino-pretty display)
- Convert all logging to standard Pino API: log.info({data}, 'message')
- Update tests to match new logging behavior
- ECS format automatically converts msg -> message in production
- Cleaner, more readable logs matching Fastify documentation
- All 32 tests passing (25 unit + 7 integration)
- Remove messageKey config from logger (fixes pino-pretty display)
- Convert all logging to standard Pino API: log.info({data}, 'message')
- Update tests to match new logging behavior
- ECS format automatically converts msg -> message in production
- Cleaner, more readable logs matching Fastify documentation
- All 32 tests passing (25 unit + 7 integration)
- Removed createLogger() function from src/utils/logger.js - Removed createLogger tests from test/unit/utils/logger-test.spec.js - Added src/utils/logger.js to exclude list in .nycrc.unit.json - Only createFastifyLogger() is needed for Fastify's internal logging - All 25 unit tests passing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.