Repository navigation
fix(cli): accept hyphen-leading --subject values - #5593
Open
ericcurtin wants to merge 2 commits into
Open
ericcurtin wants to merge 2 commits into
ericcurtin wants to merge 2 commits into
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Contributor
Author
|
@TaylorMutch @purp PTAL, and could you please triage #4889 so the issue check can pass? Thank you! |
Contributor
Author
Contributor
Author
|
Merged main (be0b5a9). @krishicks @johntmyers PTAL, and could you please triage #4889 (needs |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
--subjectvalues that start with-inworkspace member addandremove, so the suggested remediation command works.Related Issue
Closes #4889
Changes
allow_hyphen_valueson both--subjectargs.Release Notes
Testing
cargo clippy -p openshell-cli --all-targets -- -D warningsand the new test pass. The test fails without the fix.Checklist